Contributors Guide to the Code

Philosophy

The API>RCP Precedence Rule

  • The API is more important than Readability

  • Readability is more important than Convention

  • Convention is more important than Performance

    • …unless the code is a proven hotspot.

More important than anything else is the end-user API. Conventions must step aside, and any suffering is always alleviated if the end result is a better API.

Conventions and Idioms Used

Classes

Naming

  • Follows PEP 8.

  • Class names must be CamelCase.

  • but not if they are verbs, verbs shall be lower_case:

    1. # - test case for a class
    2. class TestMyClass(Case): # BAD
    3. pass
    4. class test_MyClass(Case): # GOOD
    5. pass
    6. # - test case for a function
    7. class TestMyFunction(Case): # BAD
    8. pass
    9. class test_my_function(Case): # GOOD
    10. pass
    11. # - "action" class (verb)
    12. class UpdateTwitterStatus(object): # BAD
    13. pass
    14. class update_twitter_status(object): # GOOD
    15. pass

    注解

    Sometimes it makes sense to have a class mask as a function, and there is precedence for this in the stdlib (e.g. contextmanager). Celery examples include subtask, chord, inspect, promise and more..

  • Factory functions and methods must be CamelCase (excluding verbs):

    1. class Celery(object):
    2. def consumer_factory(self): # BAD
    3. ...
    4. def Consumer(self): # GOOD
    5. ...

Default values

Class attributes serve as default values for the instance, as this means that they can be set by either instantiation or inheritance.

Example:

  1. class Producer(object):
  2. active = True
  3. serializer = 'json'
  4. def __init__(self, serializer=None):
  5. self.serializer = serializer or self.serializer
  6. # must check for None when value can be false-y
  7. self.active = active if active is not None else self.active

A subclass can change the default value:

  1. TaskProducer(Producer):
  2. serializer = 'pickle'

and the value can be set at instantiation:

  1. >>> producer = TaskProducer(serializer='msgpack')

Exceptions

Custom exceptions raised by an objects methods and properties should be available as an attribute and documented in the method/property that throw.

This way a user doesn’t have to find out where to import the exception from, but rather use help(obj) and access the exception class from the instance directly.

Example:

  1. class Empty(Exception):
  2. pass
  3. class Queue(object):
  4. Empty = Empty
  5. def get(self):
  6. """Get the next item from the queue.
  7. :raises Queue.Empty: if there are no more items left.
  8. """
  9. try:
  10. return self.queue.popleft()
  11. except IndexError:
  12. raise self.Empty()

Composites

Similarly to exceptions, composite classes should be override-able by inheritance and/or instantiation. Common sense can be used when selecting what classes to include, but often it’s better to add one too many: predicting what users need to override is hard (this has saved us from many a monkey patch).

Example:

  1. class Worker(object):
  2. Consumer = Consumer
  3. def __init__(self, connection, consumer_cls=None):
  4. self.Consumer = consumer_cls or self.Consumer
  5. def do_work(self):
  6. with self.Consumer(self.connection) as consumer:
  7. self.connection.drain_events()

Applications vs. “single mode”

In the beginning Celery was developed for Django, simply because this enabled us get the project started quickly, while also having a large potential user base.

In Django there is a global settings object, so multiple Django projects can’t co-exist in the same process space, this later posed a problem for using Celery with frameworks that doesn’t have this limitation.

Therefore the app concept was introduced. When using apps you use ‘celery’ objects instead of importing things from celery submodules, this sadly also means that Celery essentially has two API’s.

Here’s an example using Celery in single-mode:

  1. from celery import task
  2. from celery.task.control import inspect
  3. from .models import CeleryStats
  4. @task
  5. def write_stats_to_db():
  6. stats = inspect().stats(timeout=1)
  7. for node_name, reply in stats:
  8. CeleryStats.objects.update_stat(node_name, stats)

and here’s the same using Celery app objects:

  1. from .celery import celery
  2. from .models import CeleryStats
  3. @app.task
  4. def write_stats_to_db():
  5. stats = celery.control.inspect().stats(timeout=1)
  6. for node_name, reply in stats:
  7. CeleryStats.objects.update_stat(node_name, stats)

In the example above the actual application instance is imported from a module in the project, this module could look something like this:

  1. from celery import Celery
  2. app = Celery(broker='amqp://')

Module Overview

  • celery.app

    This is the core of Celery: the entry-point for all functionality.

  • celery.loaders

    Every app must have a loader. The loader decides how configuration is read, what happens when the worker starts, when a task starts and ends, and so on.

    The loaders included are:

    • app

      Custom celery app instances uses this loader by default.

    • default

      “single-mode” uses this loader by default.

    Extension loaders also exist, like django-celery, celery-pylons and so on.

  • celery.worker

    This is the worker implementation.

  • celery.backends

    Task result backends live here.

  • celery.apps

    Major user applications: worker and beat. The command-line wrappers for these are in celery.bin (see below)

  • celery.bin

    Command-line applications. setup.py creates setuptools entrypoints for these.

  • celery.concurrency

    Execution pool implementations (prefork, eventlet, gevent, threads).

  • celery.db

    Database models for the SQLAlchemy database result backend. (should be moved into celery.backends.database)

  • celery.events

    Sending and consuming monitoring events, also includes curses monitor, event dumper and utilities to work with in-memory cluster state.

  • celery.execute.trace

    How tasks are executed and traced by the worker, and in eager mode.

  • celery.security

    Security related functionality, currently a serializer using cryptographic digests.

  • celery.task

    single-mode interface to creating tasks, and controlling workers.

  • celery.tests

    The unittest suite.

  • celery.utils

    Utility functions used by the celery code base. Much of it is there to be compatible across Python versions.

  • celery.contrib

    Additional public code that doesn’t fit into any other namespace.